Skip to content

FE-1403: Assemble and test the CPS interview guidance - #9321

Merged
lunelson merged 1 commit into
mainfrom
ln/fe-1403-test-cps-guidance
Aug 26, 2026
Merged

FE-1403: Assemble and test the CPS interview guidance#9321
lunelson merged 1 commit into
mainfrom
ln/fe-1403-test-cps-guidance

Conversation

@lunelson

@lunelson lunelson commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

The Brunch interviewer needs guidance on what to ask a process expert and when. This pull request lands the first draft of that guidance as six mechanism-typed "cards" and two hint fragments, replayed by hand against both baseline transcripts to see when each card would fire and what evidence it would add. The cards were tagged as domain-specific; the strategy pivot later in this stack (S-007, ADR-0006) found that they are in fact kind-level and lifted them into the SDCPN plugin file as patterns P01–P05 and P12 and as interviewing moves. This branch is the record of the cards and the replay.

🔗 Related links

  • FE-1403: Assemble and test the CPS interview guidance (internal)
  • Parent in this stack: FE-1402 / #9320
  • Card set as authored here: docs/specs/cps-interview-guidance.md (moved in FE-1404 to docs/archive/specs/cps-interview-guidance-2026-08-25.md with a banner recording the card→pattern mapping)
  • Replay: docs/evidence/proofs/design/cps-interview-guidance-desk-replay.md; plain rendering: docs/evidence/proofs/design/cps-interview-guidance-plain.md
  • Where the cards went: docs/specs/sdcpn-plugin.md (FE-1404 branch), sections Patterns and Moves

🚫 Blocked by

🔍 What does this change?

Adds the guidance specification, a two-transcript desk replay, and a plain-language rendering; amends plugin-contract.md. Each card names the mechanism it targets, the situation that fires it, the question it asks, and the evidence it expects; the replay records clause-level firings, deactivations, dispositions, and the limits of predicting from two transcripts.

🏗️ Agent notes

Stacked as #9311 → #9312 → #9313 → #9319 → #9320 → this branch → #9322.

Commit

  • 1eb01e81ad docs(brunch-agent): test CPS interview guidance

Status under S-007

Reclassified 2026-08-25 as test-bed material. Mapping recorded in the archive banner and on FE-1403: CPS-Q01–Q05 → P01–P05; GEN-Q02 → Moves, construct step 3; HINT-STATUS-GRADE → the precision-versus-source rule and P12; HINT-RESPECTFUL-CLOSE → Moves, construct step 6. The domain tag was a mis-tag: no card names the coatings plant. The singular firesWhen authoring seam carried to FE-1431 dissolved there (the when column of Patterns is prose).

Verification at authoring

Lint, typecheck, 128 unit tests, build, docs-index and link checks; contract, replay, and legibility reviews passed. Re-verified at the stack tip: 182/182 core tests.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

Reviewed on its own, docs/specs/cps-interview-guidance.md reads as an active spec; the FE-1404 branch archives it. Read the top of the stack for the current placement of each card.

🐾 Next steps

FE-1406 lifts the harness-generic patterns (P06, P09–P12) out of the plugin file after the skeleton runs.

🛡 What tests cover this?

  • packages/core/test/architecture/docs-index.test.ts — index rows and relative links.

❓ How to test this?

  1. Checkout the branch.
  2. Read docs/evidence/proofs/design/cps-interview-guidance-desk-replay.md against the two baseline transcripts.
  3. Run npx vitest run in packages/core.

📹 Demo

Documentation only.

@lunelson lunelson mentioned this pull request Aug 25, 2026
Merged
3 tasks
@vercel

vercel Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 26, 2026 2:28pm
petrinaut Ready Ready Preview Aug 26, 2026 2:28pm
petrinaut-docs Ready Ready Preview Aug 26, 2026 2:28pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Aug 26, 2026 2:28pm

Request Review

@lunelson lunelson mentioned this pull request Aug 25, 2026
Merged
3 tasks
@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Aug 25, 2026
This was referenced Aug 25, 2026
Merged
Merged
Merged
@lunelson Graphite App

lunelson commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Aug 25, 2026
Merged
Merged
@lunelson lunelson changed the title docs(brunch-agent): test CPS interview guidance FE-1403: Assemble and test the CPS interview guidance Aug 25, 2026
@lunelson
lunelson marked this pull request as ready for review August 25, 2026 12:13
@cursor

cursor Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only changes to brunch-agent specs and evidence; no runtime, auth, or publishable library behavior is modified.

Overview
Adds FE-1403 documentation for provisional CPS elicitation-pack content: a normative spec (cps-interview-guidance.md), a manual two-transcript desk replay, and a plain-language legibility rendering with strain dispositions.

The spec defines six mechanism-typed cards (five CPS-domain, one envelope-generic) plus status/grade and respectful-close fragments. Cards react to completion diagnostics only—they do not detect gaps, adjudicate completion, or treat interviewer-authored text as user evidence. A candidate disposition table in the replay records what was omitted (redundant instinct, untestable-at-desk, superseded by completion machinery, etc.).

The replay claims desk discrimination only: per-card prefix firings, expected evidence deltas, positive deactivation boundaries (e.g. C2 order-release at C2-E11), and respectful-close behavior against FE-1402’s oracle—not runtime activation or effect size (left to FE-1404).

plugin-contract.md gains a Further Notes entry linking the card IDs and flagging an authoring seam: several cards need diagnostic disjunctions under one technique, while ProposalType.affordance.firesWhen is singular—FE-1431 must decide multiplicity vs. split bindings. INDEX.md registers the three new documents.

Reviewed by Cursor Bugbot for commit 3e79463. Bugbot is set up for automated code reviews on this repo. Configure here.

@lunelson
lunelson force-pushed the ln/fe-1403-test-cps-guidance branch from 1eb01e8 to a8dca9e Compare August 25, 2026 12:52
@lunelson
lunelson force-pushed the ln/fe-1402-elicitation-completion-contract branch from b39783b to 9317252 Compare August 25, 2026 12:52
@lunelson lunelson mentioned this pull request Aug 25, 2026
Merged
3 tasks
@lunelson
lunelson requested a review from CiaranMn August 25, 2026 13:19
@lunelson
lunelson force-pushed the ln/fe-1403-test-cps-guidance branch from a8dca9e to 6e0b21f Compare August 26, 2026 08:30
@lunelson
lunelson force-pushed the ln/fe-1402-elicitation-completion-contract branch from 9317252 to 218a334 Compare August 26, 2026 08:30
This was referenced Aug 26, 2026
Open
Open
@lunelson
lunelson dismissed CiaranMn’s stale review August 26, 2026 14:02

The base branch was changed.

@lunelson
lunelson force-pushed the ln/fe-1403-test-cps-guidance branch from b708812 to 8cc1c6e Compare August 26, 2026 14:02
@cursor

cursor Bot commented Aug 26, 2026

Copy link
Copy Markdown

Merge activity

  • Aug 26, 2:03 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@lunelson
docs(brunch-agent): test CPS interview guidance
3e79463 
Assemble six mechanism-typed guidance cards and two fragments, then replay them against both FE-1361 transcripts with clause-level firings, deactivations, dispositions, and predictive limits.

Review dispositions: correct Q01/GEN timing and grades, align split artifacts with elicited ranges, retain conflict-rule probing, subtract machinery-redundant branch clarification, and carry the singular firesWhen authoring seam explicitly to FE-1431.

Verified: lint, typecheck, 128 unit tests, build, docs-index/link checks, reversible diff; contract, replay, and legibility reviews PASS.
@lunelson
lunelson force-pushed the ln/fe-1403-test-cps-guidance branch from 8cc1c6e to 3e79463 Compare August 26, 2026 14:18
@kostandinang
kostandinang self-requested a review August 26, 2026 14:18
@lunelson
lunelson added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit 1ffc581 Aug 26, 2026
48 checks passed
@lunelson
lunelson deleted the ln/fe-1403-test-cps-guidance branch August 26, 2026 14:36
This was referenced Aug 26, 2026
Open
Open
Open
Open
Open
This was referenced Aug 26, 2026
Open
Open
Open
Open
Open
This was referenced Aug 27, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kostandinang kostandinang kostandinang approved these changes
@CiaranMn CiaranMn CiaranMn left review comments

Assignees

@lunelson lunelson

Labels

area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lunelson @kostandinang @CiaranMn